[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests: avoid warnings due to implicit declaration of memset
From: |
Jim Meyering |
Subject: |
Re: [PATCH] tests: avoid warnings due to implicit declaration of memset |
Date: |
Mon, 10 Aug 2009 08:08:44 +0200 |
Bruno Haible wrote:
> Jim Meyering wrote:
>> Ok to push this fix?
>>
>> + * tests/test-select-stdin.c: Include <string.h> for decl of memset,
>
> No. test-select-stdin.c does not use memset(), therefore there is no reason
> for this file to include <string.h>.
>
> The memset() call that the warnings refers to comes from an FD_ZERO
> expansion. The problem is that Solaris' <sys/select.h> is only really
> complete when accompanied with a #include <string.h>. So let's fix that.
>
> I'm applying this:
>
> 2009-08-09 Bruno Haible <address@hidden>
>
> Make <sys/select.h> really self-contained, also on Solaris 10.
> * lib/sys_select.in.h: Include <string.h>.
> * m4/sys_select_h.m4 (gl_HEADER_SYS_SELECT): Test also against
> Solaris 10 problem.
> * tests/test-sys_select.c (main): Add check that FD_ZERO can be used.
> * doc/posix-headers/sys_select.texi: Mention the Solaris 10 problem.
Ahh...
yes, that's better.
Thanks.