[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests/test-strstr.c: Add another self-test.
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH] tests/test-strstr.c: Add another self-test. |
|
Date: |
Tue, 26 May 2009 07:22:12 -0600 |
|
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.21) Gecko/20090302 Thunderbird/2.0.0.21 Mnenhy/0.7.6.666 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
According to Eric Blake on 5/26/2009 6:56 AM:
> Yes, adding to the test is a good first step, and we can use the feedback
> to decide how much else we might need to do. Is the bug also present in
> gnulib's strstr replacement?
To answer my own question:
http://www.alphalinux.org/archives/axp-list/March2001/0337.shtml
It looks like the bug is alpha-specific in memchr, which means it will
manifest itself with gnulib's strstr, as well as in anything else that
uses memchr to search for a trailing \0 with a length longer than the
allocated memory, if we don't replace the broken memchr implementation.
In other words, even code like vasnprintf.c is also suspect, because it
uses memchr(,\0,) under the hood for %.*s.
- --
Don't work too hard, make some time for fun as well!
Eric Blake address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkob7QQACgkQ84KuGfSFAYALgwCeONMrRB7UyEbuK4p6DVMcuedh
CAAAoIFNiaXf9uox427wVOoNJvSyMYjp
=uQSY
-----END PGP SIGNATURE-----
- [PATCH] tests/test-strstr.c: Add another self-test., Simon Josefsson, 2009/05/26
- Re: [PATCH] tests/test-strstr.c: Add another self-test., Eric Blake, 2009/05/26
- Re: [PATCH] tests/test-strstr.c: Add another self-test., Simon Josefsson, 2009/05/26
- Re: [PATCH] tests/test-strstr.c: Add another self-test., Eric Blake, 2009/05/26
- Re: [PATCH] tests/test-strstr.c: Add another self-test.,
Eric Blake <=
- Re: [PATCH] tests/test-strstr.c: Add another self-test., Bruno Haible, 2009/05/26
- Re: [PATCH] tests/test-strstr.c: Add another self-test., Eric Blake, 2009/05/26
- required memchr behavior (was: [PATCH] tests/test-strstr.c: Add another self-test.), Eric Blake, 2009/05/29
- Re: required memchr behavior, Matthew Woehlke, 2009/05/29
- Re: required memchr behavior, Eric Blake, 2009/05/29
- Re: required memchr behavior, Matthew Woehlke, 2009/05/29
- Re: required memchr behavior, Eric Blake, 2009/05/29
- Re: required memchr behavior, Jim Meyering, 2009/05/30
- Re: required memchr behavior (was: [PATCH] tests/test-strstr.c: Add another self-test.), Bruno Haible, 2009/05/31
- Re: required memchr behavior, Jim Meyering, 2009/05/31