bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: wait-process cosmetics


From: Bruno Haible
Subject: Re: wait-process cosmetics
Date: Sun, 1 Mar 2009 18:01:30 +0100
User-agent: KMail/1.9.9

Eric Blake wrote:

>    /* waitpid() is just as portable as wait() nowadays.  */
> -  int status;
> +  int status = 0;
> 
>    if (termsigp != NULL)
>      *termsigp = 0;
> -  *(int *) &status = 0;
>    for (;;)
>      {

Applied as follows:


2009-03-01  Eric Blake  <address@hidden>

        * lib/wait-process.c (wait_subprocess): Remove unnecessary cast.

--- lib/wait-process.c.orig     2009-03-01 17:59:34.000000000 +0100
+++ lib/wait-process.c  2009-03-01 17:58:16.000000000 +0100
@@ -1,5 +1,5 @@
 /* Waiting for a subprocess to finish.
-   Copyright (C) 2001-2003, 2005-2008 Free Software Foundation, Inc.
+   Copyright (C) 2001-2003, 2005-2009 Free Software Foundation, Inc.
    Written by Bruno Haible <address@hidden>, 2001.
 
    This program is free software: you can redistribute it and/or modify
@@ -292,7 +292,7 @@
 
   if (termsigp != NULL)
     *termsigp = 0;
-  *(int *) &status = 0;
+  status = 0;
   for (;;)
     {
       int result = waitpid (child, &status, 0);
@@ -308,7 +308,7 @@
            {
              /* Child process nonexistent?! Assume it terminated
                 successfully.  */
-             *(int *) &status = 0;
+             status = 0;
              break;
            }
 # endif




reply via email to

[Prev in Thread] Current Thread [Next in Thread]