[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: support for universal binaries on MacOS X (5/6)
From: |
Bruno Haible |
Subject: |
Re: support for universal binaries on MacOS X (5/6) |
Date: |
Fri, 26 Dec 2008 13:17:48 +0100 |
User-agent: |
KMail/1.9.9 |
Hi Jim,
> It looks to me like the change below is equivalent to yours,
Ah, I see now what you mean. Fine with me.
I wouldn't have chosen this solution because it tears apart the
determination of the ac_cv_func_working_mktime into two parts,
one before the AC_CACHE_CHECK and one inside it (making the logic
more complex) and because the configure output will show
checking for working mktime... (cached) no
already at the first invocation of the macro.
> Then the nesting/logic of the majority of lines in
> that file doesn't change.
I find it normal to reindent even large chunks of code, when needed
for the outer logic. With cvs, I could do "cvs diff -w". With git,
"git diff --color-words" can convince you quickly that only the
indentation has changed.
Anyway, it's your .m4 files, your decision.
Bruno
Re: support for universal binaries on MacOS X (5/6), Peter O'Gorman, 2008/12/27