Re: Alan Hourihane: [bug #24687] implicit usage of mbsinit & mbrtowc

[Albert Chin]

On Thu, Oct 30, 2008 at 12:42:48PM +0100, Bruno Haible wrote:
> Hello Sergey,
> 
> > > This renders compilation of 4.13 inoperable on these systems, and
> > > you get the build errors below....
> > > 
> > > display.o:display.o:(.text+0x786): undefined reference to `mbrtowc'
> > > display.o:display.o:(.text+0x78c): undefined reference to `mbsinit'
> 
> The problem is that texinfo's info.h includes mbiter.h
> unconditionally, whereas the module description in gnulib specifies
> this:
> 
> Include:
> #if HAVE_MBRTOWC
> #include "mbiter.h"
> #endif
> 
> Now I see that you have 9 functions in
> texinfo/info/{display.c,session.c,window.c} which use the mbiter
> facility unconditionally, and you probably have no interest in adding
> fallback code for older systems for each of these functions.
> 
> I'll therefore extend the modules in a way that they work also on older
> systems without HAVE_MBRTOWC.
> 
> Something like this. Probably also adding replacements for btowc and mbrtowc.
>
> [ snip snip ]

Any plans to commit the patch?

-- 
albert chin (address@hidden)