[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
getgroups: test: =: unary operator expected
From: |
Simon Josefsson |
Subject: |
getgroups: test: =: unary operator expected |
Date: |
Wed, 22 Oct 2008 14:14:32 +0200 |
User-agent: |
Gnus/5.110011 (No Gnus v0.11) Emacs/22.2 (gnu/linux) |
Jim, the getgroups m4 check causes errors on mingw:
./configure: line 8004: test: =: unary operator expected
The problem is this code:
AC_REQUIRE([AC_FUNC_GETGROUPS])
if test $ac_cv_func_getgroups_works = no; then
The AC_FUNC_GETGROUPS function doesn't set ac_cv_func_getgroups_works if
there is no getgroups function at all, which is the case on mingw.
The patch below fixes the configure error, although maybe other
solutions are more preferred.
/Simon
>From 372854e7458969151cd1ec722670f17685479b20 Mon Sep 17 00:00:00 2001
From: Simon Josefsson <address@hidden>
Date: Wed, 22 Oct 2008 14:13:47 +0200
Subject: [PATCH] getgroups: Avoid invoking test with wrong parameters.
---
ChangeLog | 4 ++++
m4/getgroups.m4 | 6 +++---
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 0dca26b..bd0a10a 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2008-10-22 Simon Josefsson <address@hidden>
+
+ * m4/getgroups.m4: Avoid invoking test with wrong parameters.
+
2008-10-22 Eric Blake <address@hidden>
glthread/thread: avoid compiler warning
diff --git a/m4/getgroups.m4 b/m4/getgroups.m4
index edc2bde..0364752 100644
--- a/m4/getgroups.m4
+++ b/m4/getgroups.m4
@@ -1,9 +1,9 @@
-#serial 10
+#serial 11
dnl From Jim Meyering.
dnl A wrapper around AC_FUNC_GETGROUPS.
-# Copyright (C) 1996, 1997, 1999, 2000, 2001, 2002, 2003, 2004 Free
+# Copyright (C) 1996, 1997, 1999, 2000, 2001, 2002, 2003, 2004, 2008 Free
# Software Foundation, Inc.
#
# This file is free software; the Free Software Foundation
@@ -13,7 +13,7 @@ dnl A wrapper around AC_FUNC_GETGROUPS.
AC_DEFUN([gl_FUNC_GETGROUPS],
[
AC_REQUIRE([AC_FUNC_GETGROUPS])
- if test $ac_cv_func_getgroups_works = no; then
+ if test "$ac_cv_func_getgroups_works" != yes; then
AC_LIBOBJ(getgroups)
AC_DEFINE(getgroups, rpl_getgroups,
[Define as rpl_getgroups if getgroups doesn't work right.])
--
1.5.6.5
- getgroups: test: =: unary operator expected,
Simon Josefsson <=