Re: [PATCH 1/2] selinux-h: new module (from coreutils/gl/)

[Bruno Haible]

Two more remarks:

Jim Meyering wrote:
> +# define security_context_t char*

Is it really a 'char *' also in the real SELinux? If not, then this typedef
will allow assigments between security_context_t and string values, without
producing gcc warnings. If you want to avoid this possibility, something like

  #define security_context_t struct selinux_security_context *

would be better.

Also, better use typedef than #define: It avoids hassles when the
user wants to declare two variables of the type in a single line, like this:

  security_context_t ctxt1, ctxt2;

Bruno