Re: strtod bugs

[Jim Meyering]

Jim Meyering <address@hidden> wrote:
> Eric Blake <address@hidden> wrote:
> ...
>> Therefore, I'm asking for opinions - should I apply this patch as is, to
>
> Seems fine that you've applied it, except for a new failure
> in coreutils' running of the gnulib strtod test.  E.g.,

The buildbot is also showing a new compile failure:

  http://buildbot.proulx.com:9000/

cc1: warnings being treated as errors
strtod.c: In function 'rpl_strtod':
strtod.c:54: warning: pointer targets in assignment differ in signedness
strtod.c:194: warning: declaration of 'exp' shadows a global declaration
/usr/include/bits/mathcalls.h:101: warning: shadowed declaration is here
strtod.c:198: warning: pointer targets in passing argument 1 of 'strtol' differ 
in signedness
strtod.c:216: warning: pointer targets in assignment differ in signedness
make[3]: *** [strtod.o] Error 1
make[3]: Leaving directory 
`/usr/local/build/coreutils/build-i686-gnu-linux-format/build/project/lib'
make[2]: *** [all] Error 2
make[2]: Leaving directory 
`/usr/local/build/coreutils/build-i686-gnu-linux-format/build/project/lib'
make[1]: *** [all-recursive] Error 1