bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] gnumakefile: Don't double-quote-expand $(VPATH) value.


From: Jim Meyering
Subject: [PATCH] gnumakefile: Don't double-quote-expand $(VPATH) value.
Date: Wed, 26 Mar 2008 00:10:43 +0100

FYI, more on principle than anything else, but
this avoids nastiness if VPATH has a pathological value
like '`echo bad things > /etc/passwd`':

        gnumakefile: Don't double-quote-expand $(VPATH) value.
        * modules/gnumakefile (clean-GNUmakefile): Use single quotes.

diff --git a/modules/gnumakefile b/modules/gnumakefile
index af85344..8559770 100644
--- a/modules/gnumakefile
+++ b/modules/gnumakefile
@@ -21,7 +21,7 @@ m4_if(m4_version_compare([2.61a.100],
 Makefile.am:
 distclean-local: clean-GNUmakefile
 clean-GNUmakefile:
-       if test x"$(VPATH)" != x ; then rm -f $(top_srcdir)/GNUmakefile ; fi
+       if test x'$(VPATH)' != x ; then rm -f $(top_srcdir)/GNUmakefile ; fi

 Include:

--
1.5.5.rc0.22.g467c




reply via email to

[Prev in Thread] Current Thread [Next in Thread]