bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Generalize GNUmakefile, ...


From: Jim Meyering
Subject: Re: [PATCH] Generalize GNUmakefile, ...
Date: Sat, 22 Mar 2008 17:35:14 +0100

Eric Blake <address@hidden> wrote:

> According to Bruno Haible on 3/13/2008 6:15 PM:
> | gnulib-tool can already put a file at the top directory of a package -
> you just
> | have to put the original into the top directory of gnulib.
> |
> | But since a GNUmakefile in the top directory of gnulib would hide the
> Makefile
> | of gnulib, I propose to move it from build-aux/GNUmakefile to
> top/GNUmakefile,
> | and enhance gnulib-tool with a filename rewriting rule that transforms
> |   $GNULIBDIR/top/GNUmakefile   -->   $PACKAGEDIR/GNUmakefile
>
> How about like this?  To test it, I split maintainer-makefile into two
> modules (for now, I'm ready for a shared GNUmakefile but not gnulib's
> maint.mk in M4), then used 'gnulib-tool --import GNUmakefile' in M4.  OK
> to apply?
>
> --
> Don't work too hard, make some time for fun as well!
>
> Eric Blake             address@hidden
>>From c1de993fed29331d1cbe36c2a9f0d1818626b800 Mon Sep 17 00:00:00 2001
> From: Eric Blake <address@hidden>
> Date: Fri, 21 Mar 2008 22:29:37 -0600
> Subject: [PATCH] Support installing files into the top directory.
>
> * gnulib-tool (func_get_automake_snippet): Distribute files placed
> in the top directory.
> (func_emit_lib_Makefile_am): Manage files in the top directory.
> (func_emit_tests_Makefile_am): Likewise.
> (func_import): Likewise.
> (func_create_testdir): Likewise.
> * modules/maintainer-makefile: Split, and add dependency...
> * modules/GNUmakefile: to this new module.
> * build-aux/GNUmakefile: Move...
> * top/GNUmakefile: ...here.
> * build-aux/maint.mk: Move...
> * top/maint.mk: ...here.

At least after the 2-minute glance-through it looks fine.
Thanks for doing all that!




reply via email to

[Prev in Thread] Current Thread [Next in Thread]