Re: GNU-style ChangeLog merge driver for Git

[Bruno Haible]

Hello Ralf,

> A couple of minor nits:
> 
> * Bruno Haible wrote on Mon, Feb 11, 2008 at 01:15:47AM CET:
> > bin_PROGRAMS = git-merge-changelog
> > git_merge_changelog_LDADD = -L. -lgnu
> 
> Please make this 
>   git_merge_changelog_LDADD = libgnu.a
> 
> so that automake notices and adds the dependency, so that a parallel
> build does not fail.

Done. Thanks for noticing this.

> > /* Installation:
> >    $ gnulib-tool --create-testdir --dir=/tmp/testdir123 git-merge-changelog
> >    $ cd /tmp/testdir123
> >    $ ./configure
> >    $ make
> >    $ make install
> 
> This creates a file
>   $prefix/share/dummy/javaversion.class
> 
> Surely that 'dummy' is weird, but the file should not be needed at all,
> no?

I cannot reproduce this. You must have an extraneous dependency to the
module 'javacomp' or 'javaversion' somewhere?

Bruno


2008-02-11  Bruno Haible  <address@hidden>

        * modules/git-merge-changelog (Makefile.am): Don't use -L and -l for a
        library in the current directory: it does not work with parallel make.
        Reported by Ralf Wildenhues <address@hidden>.

*** modules/git-merge-changelog.orig    2008-02-12 00:09:55.000000000 +0100
--- modules/git-merge-changelog 2008-02-12 00:08:10.000000000 +0100
***************
*** 24,30 ****
  
  Makefile.am:
  bin_PROGRAMS = git-merge-changelog
! git_merge_changelog_LDADD = -L. -lgnu
  
  Include:
  
--- 24,30 ----
  
  Makefile.am:
  bin_PROGRAMS = git-merge-changelog
! git_merge_changelog_LDADD = libgnu.a
  
  Include: