Re: Recommended headers include order

[Eric Blake]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Bruno Haible on 1/10/2008 7:24 PM:
| Thanks for these. So the problem is that if __STRICT_ANSI__ is set,
| __attribute__(...) gets defined to empty. In some tests with GCC versions
| starting from 2.95.3, I found that __attribute__ works also with
| __STRICT_ANSI__, therefore there is no need to define it away.

Seems fine to me, since the compilation failure was detected by my edits
to string.in.h, and I was just copying what was done elsewhere.  Does
anyone know why we started checking __STRICT_ANSI__ in the first place?

| +++ lib/error.h       2008-01-11 01:53:27.000000000 +0100
| @@ -20,7 +20,7 @@
|
|  #ifndef __attribute__
|  /* This feature is available in gcc versions 2.5 and later.  */
| -# if __GNUC__ < 2 || (__GNUC__ == 2 && __GNUC_MINOR__ < 5) ||
__STRICT_ANSI__
| +# if __GNUC__ < 2 || (__GNUC__ == 2 && __GNUC_MINOR__ < 5)
|  #  define __attribute__(Spec) /* empty */
|  # endif

Doesn't changing files like error.h break sync with glibc?  Maybe it's
worth asking the glibc list about their habits?

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHhtVw84KuGfSFAYARAjqZAKDZxrLljMY101FbaE+AcCG5nMTy7gCfZVuT
8hkx6s0r5At1T9EbP3eQw8A=
=DsAR
-----END PGP SIGNATURE-----