bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: gnulib support for st_birthtime (second revision of patch)


From: James Youngman
Subject: Re: gnulib support for st_birthtime (second revision of patch)
Date: Tue, 27 Mar 2007 12:49:54 +0100

Changed test_birthtime's return value to 'void', since the function falls
off without providing a return value, and since the return value is effectively
not used.

Changed NFILES from 5 to 4, to avoid using uninitialized values.

Removed the "1 || " in the test, that disabled the test_birthtime test,
probably a leftover from your tests.

Argh.  Sorry about those defects.  Thanks for cleaning up the mess :)

The fact that I failed to remove the "1 ||" means that contrary to
wehat I said earlier, this version of the patch was not tested on
NetBSD-3.1 with UFS2.  Sigh.

James.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]