bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-tar] argp-help and program name


From: Eric Blake
Subject: Re: [Bug-tar] argp-help and program name
Date: Fri, 09 Dec 2005 07:05:01 -0700
User-agent: Mozilla Thunderbird 1.0.2 (Windows/20050317)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Sergey Poznyakoff on 12/9/2005 3:21 AM:
> 
> Yes, and yet another function that assumes '/' as the directory
> separator is argp_parser. While argp-help can be tweaked to use
> base_name, it is harder to do so in argp_parser, since that would
> imply the necessity to free state->name afterwards. Allow me some
> time to work out the solution.

Once my dirname patch is applied, there will be last_component which does
the same thing as what your new __argp_base_name does.  Prior to my
dirname patch, the existing base_name does the same as your
__argp_base_name (that is, find the base name within a string rather than
allocating a copy).  By using the correct method to get the basename, you
can avoid having to free state->name afterwards.

Usually, module owners post their patches to bug-gnulib for review, so I
was a bit surprised when you just applied it; but it did work for me.

- --
Life is short - so eat dessert first!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFDmY8M84KuGfSFAYARAvWyAJwOWE0V886y4l/CX+AQ2znBVmuesgCgmnnR
M/TVFr9rd8lS1sPKf8W6cko=
=wPYs
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]