bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: gnulib features.h?


From: Paul Eggert
Subject: Re: gnulib features.h?
Date: Thu, 15 Sep 2005 13:19:06 -0700
User-agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.4 (gnu/linux)

Derek Price <address@hidden> writes:

> 2005-09-15  Derek Price  <address@hidden>
>  
>        * regex_internal.h: Blank `pure' for GNUC < 3.
>        * regex_internal.c: Ditto, using this...
>        (__GNUC_PREREQ): ...new macro.
>        * regcomp.c, regexec.c: Blank `always_inline' for GNUC < 3.1 using...
>        (__GNUC_PREREQ): ...this new macro.

We don't need all thse definitions of __GNUC_PREREQ, since
regex_internal.h is included before the other .c files are; see
regex.c.  Could you please simplify the patch accordingly?  Only
regex_internal.h should need changes from yesterday's state; the other
files can remain unchanged from yesterday.  Thanks.

(I see you didn't pick up on my features.h idea.  That's OK; we can do
it later if people like it....)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]