bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: getline: protect prototype better


From: Jim Meyering
Subject: Re: getline: protect prototype better
Date: Tue, 23 Aug 2005 17:07:59 +0200

Simon Josefsson <address@hidden> wrote:
> How about this?  If for some reason HAVE_DECL_GETLINE is not defined
> at all, the header file fail to parse.  This uses the idiom that is
> suggested by the autoconf manual.
>
> 2005-08-23  Simon Josefsson  <address@hidden>
>
>       * getline.h (getline): Protect prototype better.
>
> --- getline.h 17 Jul 2005 11:39:14 +0200      1.16
> +++ getline.h 23 Aug 2005 13:28:13 +0200
> @@ -23,6 +23,6 @@
>  # include <stdio.h>
>  # include <sys/types.h>
>
> -#if !HAVE_DECL_GETLINE
> +#if defined(HAVE_DECL_GETLINE) && !HAVE_DECL_GETLINE

That's fine.  Thanks.
But would you please remove the parentheses? e.g.

  #if defined HAVE_DECL_GETLINE && !HAVE_DECL_GETLINE

I've been trying to remove such unnecessary syntax,
over the years.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]