bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: regex problems


From: Sam Steingold
Subject: Re: regex problems
Date: Fri, 05 Aug 2005 11:24:33 -0400
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (windows-nt)

> * Bruno Haible <address@hidden> [2005-08-04 13:22:12 +0200]:
>
> Sam Steingold wrote:
>> > This patch should work. ...
>>
>> will you check this into the gnulib CVS?
>
> I'm waiting for other people's opinion, especially Paul Eggert's one.
> (The regex module is owned by "all".)

here are 2 more issues:

1. warning:

In file included from regex.c:85:
regex_internal.c:37: warning: `inline' is not at beginning of declaration
regex_internal.c:1381: warning: `inline' is not at beginning of declaration

fixed by:

--- regex_internal.c    07 Jul 2005 04:08:39 -0400      1.1
+++ regex_internal.c    05 Aug 2005 11:17:06 -0400      
@@ -34,7 +34,7 @@
                                          const re_node_set *nodes,
                                          unsigned int context,
                                          unsigned int hash) internal_function;
-static unsigned int inline calc_state_hash (const re_node_set *nodes,
+static inline unsigned int calc_state_hash (const re_node_set *nodes,
                                            unsigned int context) 
internal_function;
 
 /* Functions for string operation.  */
@@ -1378,7 +1378,7 @@
   return dfa->nodes_len++;
 }
 
-static unsigned int inline
+static inline unsigned int
 calc_state_hash (nodes, context)
      const re_node_set *nodes;
      unsigned int context;

2. warning:

In file included from regex.c:87:
regexec.c: In function `sift_states_bkref':
regexec.c:2162: warning: comparison of unsigned expression < 0 is always false

fixed by

--- regexec.c   07 Jul 2005 04:08:39 -0400      1.1
+++ regexec.c   05 Aug 2005 11:22:35 -0400      
@@ -2159,7 +2159,7 @@
          local_sctx.last_node = node;
          local_sctx.last_str_idx = str_idx;
          err = re_node_set_insert (&local_sctx.limits, enabled_idx);
-         if (BE (err < 0, 0))
+         if (BE (err != REG_NOERROR, 0))
            {
              err = REG_ESPACE;
              goto free_return;



>> > Does the definition of AC_CHECK_HEADERS_ONCE also find its way into
>> > the aclocal.m4 file? ...
>> no, aclocal.m4 does not have the definition.
> That's the problem. Fix that, and it will work.
how do you fix it?

-- 
Sam Steingold (http://www.podval.org/~sds) running w2k
<http://ffii.org/> <http://www.dhimmi.com/> <http://www.iris.org.il>
<http://www.mideasttruth.com/> <http://www.honestreporting.com>
If You Want Breakfast In Bed, Sleep In the Kitchen.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]