[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug-gnulib] Re: DNS SRV: getsrv/freesrvhost

From: Simon Josefsson
Subject: [bug-gnulib] Re: DNS SRV: getsrv/freesrvhost
Date: Sun, 26 Dec 2004 15:05:21 +0100
User-agent: Gnus/5.110003 (No Gnus v0.3) Emacs/21.3.50 (gnu/linux)

Paul Eggert <address@hidden> writes:

> Simon Josefsson <address@hidden> writes:
>> http://lists.gnu.org/archive/html/bug-gnulib/2004-12/msg00055.html
> I suspect that nobody else needs the function, which is why nobody
> replied.  If only one program needs it, I'd leave it in that program
> for now.

I'm currently using it in Shishi, but I'm going to use it in gsasl
too, and it may be used in InetUtils.

> The copying conditions seem OK, but a quick glance shows the code
> isn't portable, e.g., it assumes int is the same width as pointer.
> And it uses bad coding style, e.g., it doesn't check whether malloc
> returns NULL.  It might be better to start over.

I'll try to rewrite it cleanly.  The biggest problem is the fixed size
buffer in the call to res_query...  Perhaps one could modularize adns,
although it uses assert frequently and might not be portable for other
reasons as well.  Thoughts?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]