Re: [bug-gnulib] Re: iconv made easy

[Paul Eggert]

Simon Josefsson <address@hidden> writes:

> +    {
> +      char *q;
> +
> +      q = malloc (strlen (str) + 1);
> +      if (!q)
> +     return NULL;
> +
> +      return strcpy (q, str);
> +    }

One minor point: this could be "return strdup (str);", though you
should depend on the strdup module if you do that.

Another, less minor point: errno is garbage some times when
iconv_string fails, e.g., when have_error == 1.