|
From: | Gary V. Vaughan |
Subject: | Re: [Bug-gnulib] Patch proposal: 1-gary-safe-xfree.patch |
Date: | Thu, 11 Sep 2003 15:15:47 +0100 |
User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5b) Gecko/20030903 Thunderbird/0.2 |
Paul Eggert wrote:
I suppose we could use Autoconf to test whether 'free (NULL)' works, and optimize xfree in that case. This would improve performance only for native compiles, but that's an important special case.
I was about to do this, but there are two problems: i) how do we know that `free (NULL)' has worked for the purposes of autoconf? Maybe it just corrupts the heap and doesn't SEGV... ii) including config.h means that xalloc.h can't be installed anymore if xfree is to be declared there. I propose applying your patch without autoconfigury... Cheers, Gary. -- ())_. Gary V. Vaughan gary@(lilith.warpmail.net|gnu.org) ( '/ Research Scientist http://www.oranda.demon.co.uk ,_())____ / )= GNU Hacker http://www.gnu.org/software/libtool \' `& `(_~)_ Tech' Author http://sources.redhat.com/autobook =`---d__/
[Prev in Thread] | Current Thread | [Next in Thread] |