bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-gnulib] changes for getloadavg.c


From: Jim Meyering
Subject: Re: [Bug-gnulib] changes for getloadavg.c
Date: Thu, 05 Jun 2003 23:00:35 +0200

Paul Eggert <address@hidden> wrote:

> Dave Love <address@hidden> writes:
>
>> ! #if !defined(HAVE_LIBKSTAT) && defined(LOAD_AVE_TYPE)
>
> A minor style nit: there should be a space before the '('.
>
> If we can assume C89, we can omit the parentheses entirely; that's a
> better style.  But if Emacs still can't assume C89 then I guess the
> parentheses might be needed.  (I never ran into a compiler that
> required them, myself; does anybody else know what they were?)

I've been removing such parentheses even longer than I've
been writing `#if HAVE_POSSIBLY_NOT_DEFINED'.
I vote to nuke 'em.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]