[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-gnulib] addition: binary-io.h
From: |
Jim Meyering |
Subject: |
Re: [Bug-gnulib] addition: binary-io.h |
Date: |
Wed, 02 Apr 2003 10:24:44 +0200 |
Bruno Haible <address@hidden> wrote:
> A new module which allows to set file descriptors to binary mode on
> platforms where this makes a difference. Mostly taken from coreutils.
>
> OK to add?
Hi Bruno,
Thank you. This looks good.
A couple of formatting nits:
-----------------------
Please omit the redundant parentheses here:
# if !(defined(__EMX__) || defined(__DJGPP__))
this style is more consistent:
# if !(defined __EMX__ || defined __DJGPP__)
-----------------------
Please put a space before an opening parenthesis
and after each comma on the RHS of a #define:
# define SET_BINARY(fd) (!isatty(fd) ? (setmode(fd,O_BINARY), 0) : 0)
# else
# define SET_BINARY(fd) setmode(fd,O_BINARY)
i.e.
# define SET_BINARY(fd) (!isatty (fd) ? (setmode (fd, O_BINARY), 0) : 0)
# else
# define SET_BINARY(fd) setmode (fd, O_BINARY)