[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-gnubg] PATCH ATTACHED: Problem in latest commit of gnubg.c
From: |
Michael Petch |
Subject: |
Re: [Bug-gnubg] PATCH ATTACHED: Problem in latest commit of gnubg.c |
Date: |
Sun, 11 Apr 2004 15:07:58 -0600 |
Hello Petr,
Thanks. when I committed that change I was wondering why there was an
#else. Win32 is the reason. And it was the only platform I did not
rebuild on. You have my apologies
Checking for WIN32 at compile time is the best idea to solve this.
On Sun, 2004-04-11 at 14:49, Petr Kadlec wrote:
> Hi again!
>
> In the latest commit of gnubg.c (version 1.548, 2004/04/11 17:26:08), Joern
> has removed line 7710 (containing #else, that separates "if( !getenv(
> "DISPLAY" ) ) fX = FALSE;" to only non-USE_GTK builds). I don't know if
> that #else should be there or not (in fact, it really seems quite logical
> to remove it), but I know that my Win32 build is unusable with the new
> code, because there is no DISPLAY environment variable on Win32, so that
> gnubg disables GUI, which in turn causes the application to disappear (it
> seems that the application terminates, which is not true, it just does not
> have any visible representation).
> Probably, the #else should be removed, but that test on DISPLAY should be
> #ifdef-ed out for WIN32.
>
> Petr
>
> --
> "Accidents don't just happen; they must be carelessly planned." -- Disney
>
>
>
> _______________________________________________
> Bug-gnubg mailing list
> address@hidden
> http://mail.gnu.org/mailman/listinfo/bug-gnubg
--
Mike Petch
CApp::Sysware Consulting Ltd.
Suite 1002,1140-15th Ave SW.
Calgary, Alberta, Canada.
T2R 1K6.
(403)804-5700.
gnubg.c.patch
Description: Text Data
signature.asc
Description: This is a digitally signed message part