Re: [Bug-gnubg] winsocket - threads Win32 builds

[Nardy Pillards]

From: "Holger" <address@hidden>
Sent: Friday, July 18, 2003 2:38 PM
Subject: Re: [Bug-gnubg] winsocket - threads Win32 builds
> >
> >Yes, it does work :-) TY.
> >
> >However: compiling without HAVE_SOCKETS 1 generates link errors from
> >gnubg.c.
>
> You need -lwsock32 in Makefile.

No, I don't need -lwsock32 when I have #undef HAVE_SOCKETS in configure.h

>
> >Line 3784 (WSACleanup) and line 7127 (WSAStartup) are socket related.
> >Add #if HAVE_SOCKETS ??
>
> I'm not really fond of HAVE_SOCKETS for use on Windows since Winsock is
> after all no full BSD socket replacement. I'd rather introduce a new
define
> USE_WINSOCK. 'USE' because every 32bit Windows comes with at least version
> 1 of Winsock, thus _has_ it anyway. And because of this imho it's not
> necessary to compile without sockets support. One could remove the
> HAVE_SOCKETS checks for Windows, though.

Just adding #if HAVE_SOCKETS in gnubg.c (as is done in the other sources)
leaves the option open to use or not use winsock at this time.
There is no option now.
I have no problem going for the 'no option'. It's not a big deal, but it is
not a big deal adding twice #if HAVE_SOCKETS either, is it??

Nardy

> Regards,
>
>          Holger
>
>