Re: [Bug-gnubg] experimental support for Hugh Sconyers'full15x15bearoff

[Joern Thyssen]

On Fri, Jul 11, 2003 at 08:32:50PM +0200, Holger wrote
> At 20:13 11.07.2003 +0200, Nardy Pillards wrote:
> >From: "Holger" <address@hidden>
> >Sent: Friday, July 11, 2003 6:32 PM
> >
> >> At 17:48 11.07.2003 +0200, Nardy Pillards wrote:
> >> >Win32 builds: path to DVD-drive
> 
> >Let me be clear:
> >J:/ J:\ J:// J:\\ don't do the job
> >J: does
> >(J being my DVD-drive ;-) )
> >
> >If a gnubg user will issue the command:
> >set bearoff sconyers 15x15 DVD path "[DVD-drive]:/"
> >(or whatever combiniation of slash and backslash)
> >it will not work.
> >He/She will have to wait 30 seconds before getting the 'OK - Cancel' widget
> >(and getting that twice).
> >
> >That's why I proposed to change the tooltip to say:
> >.......  'D:' instead of
> >....... 'D:/'
> 
> I haven't looked at this part of the code. It's a bit strange that it 
> doesn't work with slash(es). But if D: is the only solution (the other 
> might be to fix the path string handling if it's broken), then this can be 
> changed easily.

This could be a minor bug in PathOpen (path.c). PathOpen tries several
paths constructed from the passed arguments. Unfortunately, it uses a
hardcoded forward slash as directory separator, e.g., when passed J:\
and bg15_1.dat if tries opening J:\/bg15_1.dat which fails. Instead it
should use DIR_SEPERATOR from backgammon.h: J:\\bg15_1.dat.

I've commited a fix. Nardy, can you check that it works?

The "set ... dvd path" command should look similar to the "set path ..."
commands. As I don't run windows I don't know how if you should write:

set bearoff sconyers 15x15 dvd path J:\
set bearoff sconyers 15x15 dvd path J:\\
set bearoff sconyers 15x15 dvd path "J:\\"

The problem with just using J: is that it is a relative path, e.g., if
the current J: directory is whatever\ then windows will translate J: to
J:\whatever\, which is not what we want.

Jørn