[Bug-gnubg] Re: one (picky) warning

[Jim Segrave]

On Sat 05 Jul 2003 (21:00 +1200), Joseph Heled wrote:
> If we want to be extra picky, I still get one warning
> 
> gnubg.c:7639: warning: passing arg 2 of `iconv' from incompatible 
> pointer type
> 
> Now, configure said it groked my proto as:
> 
>     extern size_t iconv (iconv_t cd, char * *inbuf, size_t *inbytesleft, 
> char * *outbuf, size_t *outbytesleft);
> 
> So what irkes the compiler is the extra const in 'const char ** inbuf'
> 
> A quick look at the configure script showed it need to be replaced by 
> ICONV_CONST.
> 
> Fixed in development branch.

Interesting - I was getting no warnings with my earlier fix - I
suspect it may be a change between versions of libiconv.

For a real laugh, add --pedantic to CFLAGS. 

You get lots of warnings about

String constants longer than C89 accepts
Variable array declarations
Initialisers which can't be evaluated at load time
C++ comments
Trailing commas in enum declarations
And a few other odd ones. None of these with the exception of C++
comments really looks too worrying.

-- 
Jim Segrave           address@hidden