Re: [patch] gettext-0.15, cygwin

[Bruno Haible]

Hello,

> The attached patch fixes two problems on cygwin:

Thanks for the reports.

> (1) building out-of-tree fails because the gettext-tools directory in 
> the source tree needs to be in the include path for the 
> gettext-tools/lib and gettext-tools/src subdirectories.

Thanks, I'm applying similar patches.

> (2) When building relocatable on cygwin, config.h defines DLL_VARIABLE 
> as declspec(dllimport).  This is the desired behavior for the main 
> libraries and non-wrapper applications, and works fine thanks to the 
> *.exports magic.  However, unlike MSVC and mingw, on cygwin we also 
> build the wrapper exe's.
> 
> relocwrapper.c includes config.h -- so via progname.h it gets a 
> definition of the "program_name" variable that is declspec(dllimport). 
> However, install-reloc builds the wrapper by directly compiling all 
> relevant .c files into the wrapper -- therefore the actual symbol is 
> _program_name, not __imp_program_name.
>
> Because relocwrapper is always and only compiled by install-reloc in 
> exactly the same way -- direct compilation of a list of .c's with no 
> dependent librareis -- it should never need to worry about 
> dllimport/dllexport issues.  So, after #including config.h but before 
> #including any other headers, the following is safe and effective:
> 
> #undef DLL_VARIABLE
> #define DLL_VARIABLE

Yes. But why do you apply it only to relocwrapper.c? Not also to
progname.c and progreloc.c? I will solve it by introducing yet another -D
option that has an effect on config.h, so that we don't need to touch
individual .c files.

Thanks for the reports. It's good to know that you are doing more extensive
cygwin testing than I do.

Bruno