bug-gnu-utils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: MD5 check failed on extracting shar file whose name has $


From: Bruce Korb
Subject: Re: MD5 check failed on extracting shar file whose name has $
Date: Wed, 30 Aug 2006 15:59:57 -0700
User-agent: Mozilla Thunderbird 1.0.7 (X11/20050923)

1.  Using non-portable file name characters in your file names
    is a bad choice.  Don't do it.

2.  Using characters that are special to the shell is an even
    worse idea.  White spaces cannot be gotten to work, so
    forget about it.  Parentheses, backquotes, dollar signs
    and so on are almost as bad as white space.
    Really don't do it.

3.  sharutils is almost completely unused anymore.  "tar" and
    "cpio" and other archivers would not care about funny names.
    Fortunately, it turns out to be a trivial fix.  See below.

Thank you for the translation.  I applied your patch.
Please note that it is only temporary, though.  I resync my
"po" directory with the U. Montreal translations:

http://www.iro.umontreal.ca/translation/registry.cgi?domain=sharutils

Thanks - Bruce

$ cvs diff *.*
! /usr/bin/cvs diff ...
Index: scripts.def
===================================================================
RCS file: /sources/sharutils/sharutils/src/scripts.def,v
retrieving revision 1.7
diff -b -B -u -p -r1.7 scripts.def
--- scripts.def 20 Nov 2005 18:58:54 -0000      1.7
+++ scripts.def 30 Aug 2006 22:56:02 -0000
@@ -160,7 +160,7 @@ text = {
          if ${md5check}
          then (
               ${MD5SUM} -c >/dev/null 2>&1 || ${echo} '%s: %s'
-              ) << %s
+              ) << \%s
        _EOBody_;
 };

Index: scripts.x
===================================================================
RCS file: /sources/sharutils/sharutils/src/scripts.x,v
retrieving revision 1.3
diff -b -B -u -p -r1.3 scripts.x
--- scripts.x   20 Nov 2005 19:12:26 -0000      1.3
+++ scripts.x   30 Aug 2006 22:56:02 -0000
@@ -127,12 +127,12 @@ test -n \"${f}\" && md5check=true || md5
 ${md5check} || \\\n\
   echo '%s'\n";

-static const char md5test_z[98] =
+static const char md5test_z[99] =
 #line 160 "scripts.def"
 "  if ${md5check}\n\
   then (\n\
        ${MD5SUM} -c >/dev/null 2>&1 || ${echo} '%s: %s'\n\
-       ) << %s\n";
+       ) << \\%s\n";

 static const char query_answers_z[769] =
 #line 171 "scripts.def"




reply via email to

[Prev in Thread] Current Thread [Next in Thread]