Re: [PATCH] uudecode doesn't work on files with DOS line endings

[Bruce Korb]

Paul Eggert wrote:
> Bruce Korb <address@hidden> writes:
>
>
> > > +2006-04-26  Pavel Roskin  <address@hidden>
> > > +
> > > +       * uudecode.c (read_stduu): Allow characters other than '\n'
> > > +       after "end", such as the DOS style newline "\r\n".
>
>
> Just FYI, Solaris 10 moa behaves like unpatched GNU uudecode here.
>
> POSIX seems to imply that uudecode shouldn't ignore trailing \r, but
> since common practice seems to be to strip it elsewhere I guess it's
> OK to strip it here.

Hi Paul,

Let's assume that it was POSIX' intent to require that the text end
with exactly the four character sequence 'e', 'n', 'd' and '\n'.
What is the effect of allowing an extra '\r' slipped in there?
The only thing that might break is someone's application that was
expecting to find a failure, yes?  I'm not sure I see a good reason
for caring about that.  :)  BTW, should I file an aardvark?  I do
believe in making things as simple and obvious to the user as possible.

Cheers - Bruce