PSPP-BUG: [bug #48015] Bug in gui Independent Samples GUI

[Friedrich Beckmann]

Follow-up Comment #6, bug #48015 (project pspp):

Hi John,

i also had a look at the code. The immediate problem is the assumption of
short strings in the grp_val in psppire-dialog-action-indep-samps.c:



  if (act->grp_var)
    {
      int width = var_get_width (act->grp_var);
      value_destroy (&act->cut_point, width);       <----- Here the crash,
because of free of long_string
      value_destroy (&act->grp_val[0], width);
      value_destroy (&act->grp_val[1], width);
    }

  if (v)
    {
      const int width = var_get_width (v);
      value_init (&act->cut_point, width);
      value_init (&act->grp_val[0], width);
      value_init (&act->grp_val[1], width);

      if (width == 0)
        {
          act->cut_point.f  = SYSMIS;
          act->grp_val[0].f = SYSMIS;
          act->grp_val[1].f = SYSMIS;
        }
      else
        {
          act->cut_point.short_string[0] = '\0';    <-- only o.k for width <
8, else long_string
          act->grp_val[0].short_string[0] = '\0';
          act->grp_val[1].short_string[0] = '\0';
        }
    }



To crash psppire, the group variable has to be a string with length such that
short_string is not used.

I noticed an additional problem:

The variable that is selected as group variable is not removed from the left
treeview. I think this is coded in the selector code where there is probably a
difference between treeview -> treeview and treeview->entry. 

Then you can select a variable as group variable and as test variable, is this
o.k.?

Friedrich

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?48015>

_______________________________________________
  Nachricht gesendet von/durch Savannah
  http://savannah.gnu.org/