PSPP-BUG: [bug #18922] Crashes if filenames differ only in case.

[Ben Pfaff]

Update of bug #18922 (project pspp):

                  Status:                    None => Ready for Test/Review  

    _______________________________________________________

Follow-up Comment #1:

The problem is that we're using a single member in struct file_handle, the
"name" field, for more than one purpose.  When it begins with '"', it's a
file name; otherwise, it's a token that can be used to identify it.  When
that assertion fires, it's because we searched for the name case-sensitively
as a file name (so that there was no match), and then we try to insert it
case-insensitively as a token, which fails because duplicates aren't
allowed.

Solution: break the two purposes into two separate fields.  This fixes the
problem and likely makes the code easier to read too.

Patch attached.

(file #11906)
    _______________________________________________________

Additional Item Attachment:

File name: fh-crash.patch                 Size:9 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?18922>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/