[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#70820: [PATCH] Editable grep buffers
From: |
Visuwesh |
Subject: |
bug#70820: [PATCH] Editable grep buffers |
Date: |
Thu, 09 May 2024 16:02:35 +0530 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
[புதன் மே 08, 2024] Eli Zaretskii wrote:
>> From: Visuwesh <visuweshm@gmail.com>
>> Cc: 70820@debbugs.gnu.org
>> Date: Wed, 08 May 2024 17:48:02 +0530
>>
>> [புதன் மே 08, 2024] Eli Zaretskii wrote:
>>
>> > I think having similar features that work very differently is not a
>> > good thing for Emacs. So I urge you to reconsider your decisions and
>> > make this more like occur-edit-mode. In particular, I don't
>> > understand the difficulty with using the markers and what does it have
>> > to do with the ability of having many Grep buffers.
>>
>> It is not having many Grep buffers but visiting the "original" files
>> unnecessarily that tends to be annoying.
>
> Why is this annoying?
>
>> > I don't think I understand this difficulty, either: with
>> > occur-edit-mode it is solved by making occur-edit-mode be derived from
>> > occur-mode. Couldn't you do the same with your mode?
>>
>> No because occur-mode makes occur-revert-arguments permanent-local so
>> `g' survives the major-mode changes.
>>
>> For revert-buffer alone, compilation-arguments needs to be marked
>> permanent-local. As it is a part of compile.el, I am not sure if
>> marking it as such is safe. This is why I think having a minor-mode is
>> better.
>
> It sounds like a minor issue which shouldn't have such grave
> consequences. Why do you think making compilation-arguments
> permanent-local would be a problem? We could ask people who
> frequently contribute to compile.e land grep.el if they see any
> problem with doing that.
It feels like a potential far-fetching change. But in any case, I will
give a shot at recreating the required markers, etc. for
occur-after-change-function to work. Will send a patch once I have a
working prototype.
- bug#70820: [PATCH] Editable grep buffers, (continued)
- bug#70820: [PATCH] Editable grep buffers, Eli Zaretskii, 2024/05/07
- bug#70820: [PATCH] Editable grep buffers, Visuwesh, 2024/05/07
- bug#70820: [PATCH] Editable grep buffers, Eli Zaretskii, 2024/05/08
- bug#70820: [PATCH] Editable grep buffers, Visuwesh, 2024/05/08
- bug#70820: [PATCH] Editable grep buffers, Eli Zaretskii, 2024/05/08
- bug#70820: [PATCH] Editable grep buffers,
Visuwesh <=
- bug#70820: [PATCH] Editable grep buffers, Visuwesh, 2024/05/12
- bug#70820: [PATCH] Editable grep buffers, Eli Zaretskii, 2024/05/18
- bug#70820: [PATCH] Editable grep buffers, Stefan Monnier, 2024/05/18
- bug#70820: [PATCH] Editable grep buffers, Eli Zaretskii, 2024/05/18
- bug#70820: [PATCH] Editable grep buffers, Stefan Monnier, 2024/05/18
- bug#70820: [PATCH] Editable grep buffers, Eli Zaretskii, 2024/05/18
- bug#70820: [PATCH] Editable grep buffers, Visuwesh, 2024/05/20
- bug#70820: [PATCH] Editable grep buffers, Stefan Monnier, 2024/05/18
- bug#70820: [PATCH] Editable grep buffers, Jim Porter, 2024/05/08
- bug#70820: [PATCH] Editable grep buffers, Eli Zaretskii, 2024/05/08