[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#48356: 28.0.50; choose-completion discards the suffix after the comp
From: |
Stefan Monnier |
Subject: |
bug#48356: 28.0.50; choose-completion discards the suffix after the completion boundary |
Date: |
Mon, 08 Apr 2024 19:50:07 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
> ...which translates to "/" because of the double slash -- the filesystem
> root directory (*). But that's the same data which would be used by any
> other proposed solution, too.
More or less, tho the "ideal" solution is to do that in the
completion-style code, which has a bit more knowledge about it.
> So maybe it should be either be fixed in the
> completion table (avoid adding trailing slash when the last boundary is
> already followed by slash?), or the insertion code should do some
> additional post-processing of the completion string.
I think you can fix it in the same ad-hoc way we use elsewhere: compare
the first char after the boundary with the last char of the completion
and drop one of the two if they're the same.
> + (base-suffix (let ((suffix (buffer-substring (point) end)))
> + (substring
> + suffix
> + (cdr (completion-boundaries string
> +
> minibuffer-completion-table
> +
> minibuffer-completion-predicate
> + suffix)))))
I think you want to be careful to pass (buffer-substring start (point))
rather than `string` to `completion-boundaries`.
In theory this approach can "do the wrong thing" with some completion
styles, but AFAIK they haven't been written yet. 🙂
Stefan
- bug#48356: 28.0.50; choose-completion discards the suffix after the completion boundary, Dmitry Gutov, 2024/04/08
- bug#48356: 28.0.50; choose-completion discards the suffix after the completion boundary, Dmitry Gutov, 2024/04/08
- bug#48356: 28.0.50; choose-completion discards the suffix after the completion boundary,
Stefan Monnier <=
- bug#48356: 28.0.50; choose-completion discards the suffix after the completion boundary, Dmitry Gutov, 2024/04/09
- bug#48356: 28.0.50; choose-completion discards the suffix after the completion boundary, Stefan Monnier, 2024/04/09
- bug#48356: 28.0.50; choose-completion discards the suffix after the completion boundary, Dmitry Gutov, 2024/04/10
- bug#48356: 28.0.50; choose-completion discards the suffix after the completion boundary, Eli Zaretskii, 2024/04/11
- bug#48356: 28.0.50; choose-completion discards the suffix after the completion boundary, Dmitry Gutov, 2024/04/11
- bug#48356: 28.0.50; choose-completion discards the suffix after the completion boundary, Dmitry Gutov, 2024/04/11
- bug#48356: 28.0.50; choose-completion discards the suffix after the completion boundary, Juri Linkov, 2024/04/14
- bug#48356: 28.0.50; choose-completion discards the suffix after the completion boundary, Dmitry Gutov, 2024/04/14
- bug#48356: 28.0.50; choose-completion discards the suffix after the completion boundary, Spencer Baugh, 2024/04/18
- bug#48356: 28.0.50; choose-completion discards the suffix after the completion boundary, Dmitry Gutov, 2024/04/19