|
From: | Konstantin Kharlamov |
Subject: | bug#35368: [PATCH v3] Do potentially destructive operations in prepare-commit-msg |
Date: | Thu, 16 May 2019 00:28:58 +0300 |
В Ср, мая 15, 2019 at 13:40, npostavs@gmail.com написал:
Konstantin Kharlamov <Hi-Angel@yandex.ru> writes:* build-aux/git-hooks/prepare-commit-msg: if someone occasionally putsSigned-off line, it will likely get there through -s option of git. Exploit this fact to abort before a user got a chance to type commit message.Thanks, looks good, but I think it would be helpful to explain that thisis about catching git commit -s ... in the comments of the file too.--- a/autogen.sh +++ b/autogen.sh @@ -1,4 +1,4 @@ -#!/bin/sh + #!/bin/shThis is a typo or something, right?
Oh, right, sorry about that. It wasn't supposed to get into the commit. I was testing the hook by adding this space, and apparently it leaked through to my local commit.
Thanks for your comments, I resent a v4 with a comment added, and the stray space removed.
[Prev in Thread] | Current Thread | [Next in Thread] |