[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#35624: log-view-diff regression
From: |
Dmitry Gutov |
Subject: |
bug#35624: log-view-diff regression |
Date: |
Wed, 8 May 2019 01:54:32 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 08.05.2019 0:56, Juri Linkov wrote:
bug#28466 caused a regression in 26.0.50. Maybe it's too late to fix it
in the release branch, so the patch below is for master.
The problem is that after the change a year and a half ago
log-view-diff always falls back to the previous revision
even when point is in the middle of the log buffer,
and not after the last entry.
This patch uses the previous revision only at the end of the log buffer:
Hi Juri,
I think the patch should look like the one below instead. Does it fix
your problem? It also looks "obviously correct" in my opinion.
Your proposal would fail in the presence of "Show 2X entries" (when the
log is long enough).
diff --git a/lisp/vc/log-view.el b/lisp/vc/log-view.el
index e47fad8908..e1e453115b 100644
--- a/lisp/vc/log-view.el
+++ b/lisp/vc/log-view.el
@@ -621,7 +621,8 @@ log-view-diff-common
(>= (point)
(save-excursion
(goto-char (car fr-entry))
- (forward-line))))
+ (forward-line)
+ (point))))
(setq fr (vc-call-backend log-view-vc-backend 'previous-revision
nil fr)))
(vc-diff-internal
t (list log-view-vc-backend
- bug#35624: log-view-diff regression, Juri Linkov, 2019/05/07
- bug#35624: log-view-diff regression,
Dmitry Gutov <=
- bug#35624: log-view-diff regression, Juri Linkov, 2019/05/08
- bug#35624: log-view-diff regression, Dmitry Gutov, 2019/05/09
- bug#35624: log-view-diff regression, Juri Linkov, 2019/05/09
- bug#35624: log-view-diff regression, Dmitry Gutov, 2019/05/09
- bug#35624: log-view-diff regression, Eli Zaretskii, 2019/05/10
- bug#35624: log-view-diff regression, Juri Linkov, 2019/05/11
- bug#35624: log-view-diff regression, Dmitry Gutov, 2019/05/12
- bug#35624: log-view-diff regression, Juri Linkov, 2019/05/13
- bug#35624: log-view-diff regression, Dmitry Gutov, 2019/05/13
- bug#35624: log-view-diff regression, Juri Linkov, 2019/05/14