[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#35239: 27.0.50; Some gnus-msg.el variables are unused
From: |
Basil L. Contovounesios |
Subject: |
bug#35239: 27.0.50; Some gnus-msg.el variables are unused |
Date: |
Tue, 07 May 2019 18:22:19 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
"Basil L. Contovounesios" <contovob@tcd.ie> writes:
> The user options gnus-debug-files and gnus-debug-exclude-variables have
> been unused since Emacs 24.1[1]. The following patch marks them as
> obsolete, fixes a few custom :types, and also removes the unused
> variable gnus-check-before-posting. WDYT?
>
> [1: 72aba33f59]: Merge changes made in Gnus trunk.
> 2011-07-07 23:18:23 +0000
>
> https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=72aba33f59d0ba30a01adf7aa7952b5839a8410d
>
> From 4b4fe3ed5a817f4535871c06ea001dc7d4077a96 Mon Sep 17 00:00:00 2001
> From: "Basil L. Contovounesios" <contovob@tcd.ie>
> Date: Thu, 11 Apr 2019 23:55:03 +0100
> Subject: [PATCH] Fix some gnus-msg.el variables
>
> * lisp/gnus/gnus-msg.el (gnus-gcc-externalize-attachments):
> Fix custom :type.
> (gnus-debug-files, gnus-debug-exclude-variables): Mark variables
> that have been unused since Emacs 24.1 as obsolete.
> (gnus-check-before-posting): Remove unused variable.
> ---
> lisp/gnus/gnus-msg.el | 16 ++++++++++------
> 1 file changed, 10 insertions(+), 6 deletions(-)
>
> diff --git a/lisp/gnus/gnus-msg.el b/lisp/gnus/gnus-msg.el
> index b6d649d760..b7a97f19d0 100644
> --- a/lisp/gnus/gnus-msg.el
> +++ b/lisp/gnus/gnus-msg.el
> @@ -158,9 +158,9 @@ gnus-gcc-externalize-attachments
> if nil, attach files as normal parts."
> :version "22.1"
> :group 'gnus-message
> - :type '(choice (const nil :tag "None")
> - (const all :tag "Any")
> - (string :tag "Regexp")))
> + :type '(choice (const :tag "None" nil)
> + (const :tag "Any" all)
> + regexp))
>
> (defcustom gnus-gcc-self-resent-messages 'no-gcc-self
> "Like `gcc-self' group parameter, only for unmodified resent messages.
> @@ -232,7 +232,9 @@ gnus-debug-files
> "Files whose variables will be reported in `gnus-bug'."
> :version "22.1"
> :group 'gnus-message
> - :type '(repeat (string :tag "File")))
> + :type '(repeat file))
> +
> +(make-obsolete-variable 'gnus-debug-files "it is no longer used." "24.1")
>
> (defcustom gnus-debug-exclude-variables
> '(mm-mime-mule-charset-alist
> @@ -240,7 +242,10 @@ gnus-debug-exclude-variables
> "Variables that should not be reported in `gnus-bug'."
> :version "22.1"
> :group 'gnus-message
> - :type '(repeat (symbol :tag "Variable")))
> + :type '(repeat variable))
> +
> +(make-obsolete-variable
> + 'gnus-debug-exclude-variables "it is no longer used." "24.1")
>
> (defcustom gnus-discouraged-post-methods
> '(nndraft nnml nnimap nnmaildir nnmh nnfolder nndir)
> @@ -340,7 +345,6 @@ gnus-inhibit-posting-styles
> (defvar gnus-article-yanked-articles nil)
> (defvar gnus-message-buffer "*Mail Gnus*")
> (defvar gnus-article-copy nil)
> -(defvar gnus-check-before-posting nil)
> (defvar gnus-last-posting-server nil)
> (defvar gnus-message-group-art nil)
>
> --
> 2.20.1
Lars, is this change acceptable?
Thanks,
--
Basil
- bug#35239: 27.0.50; Some gnus-msg.el variables are unused,
Basil L. Contovounesios <=