bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#34294: 27.0.50; flymake-start-on-save-buffer has no effect


From: João Távora
Subject: bug#34294: 27.0.50; flymake-start-on-save-buffer has no effect
Date: Mon, 04 Feb 2019 22:41:54 +0000
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

Juri Linkov <juri@linkov.net> writes:

>>> 4. Also I found these related entries in the same etc/TODO file:
>>>
>>>   ** Display something in the margin on lines that have compilation
>>>   errors.
>>
>> Flymake does this, even though it uses the fringe by default, but I
>> don't have more clues to what the author of this line intended.
>
> I guess this is exactly what Flymake already does.

Then maybe remove it in a fourth patch?

>>> What do you think about displaying a tooltip on the fringe indicator
>>> with the same text that is displayed on the tooltip over the location
>>> of the error in the source buffer?  It's easier to hover on the fringe
>>> than finding the location in the buffer to hover.
>>
>> I don't have any strong opinion. It's fine, I guess, but not
>> specifically tied to Flymake.  It may be difficult to implement.
>
> Yes, this is a more general feature.  I could look at how easy it
> would be to implement, and later to use in Flymake.

Fine by me.  I would personally concentrate efforts elsewhere, but you
get to work whereever you prefer.

>> BTW you can use flymake-goto-next-error and flymake-goto-prev-error to
>> navigate between errors, it's what I use all the time.
>
> Thanks for the suggestion.  I could also look how easy to integrate
> flymake-goto-next-error into the more general next-error framework that
> provides easy to type keybindings.

This would be quite welcome, especially since I think there are
revent improvements to the next-error framework.

Whatever you do to flymake.el, and I forgot to mention this earlier, you
have to make sure it still loads and works in Emacs 26.1, because
flymake.el is also distributed through ELPA.

Fifth patch.

>> So to summarize, it'd be great if you could provide the three patches to
>> implement the suggestions you gave.
>
> OK, I'll provide these three patches.  But first please look at my feedback
> on your suggestion to set flymake-no-changes-timeout to nil: after trying it,
> I see that it helps me, but also it requires setting
> flymake-start-syntax-check-on-newline to nil, because otherwise
> syntax check is started on an unsaved buffer when yanking text
> that contains newlines.

I think flymake-start-syntax-check-on-newline should just be deprecated,
set to nil, and hidden away from the user.  It doesn't make much sense:
I don't see why a newline is different from any other character.  So you
can do this in a sixth patch.

João





reply via email to

[Prev in Thread] Current Thread [Next in Thread]