bug#33791: 26.1; Eshell on Windows connecting to GNU/Linux machine using TRAMP and plink: env: ‘c:/home/jordan/test.sh’: No such file or directory

[Eli Zaretskii]

> From: Michael Albinus <michael.albinus@gmx.de>
> Cc: jordan.t.wilson@gmx.com,  33791@debbugs.gnu.org
> Date: Sat, 29 Dec 2018 12:12:56 +0100
> 
> >> As you see, it requires two changes, in esh-proc.el and tramp.el.
> >
> > I think both can be cherry-picked to emacs-26.
> 
> Done. The change in tramp.el needed some massage.
> 
> Jordan, could you pls test whether the changes I have applied to the
> emacs-26 branch work for you? See attachment for the changes.
> 
> > But do you know why we need expand-file-name here at all?
> 
> Well, in Emacs 26 we couldn't adapt exec-path for remote
> processes. This is available since Emacs 27 only.
> 
> > At the very least, the comment about start-process should be removed,
> > I think.
> 
> Done.

Thanks.

> > At the very least, this should be prominently mentioned in the
> > respective doc strings and in the ELisp manual.  As written now, this
> > is entirely undocumented.  Moreover, the part about "the local part of
> > default-directory" in the doc string and in the manual is confusing,
> > because we have no description of what that means.  The only attempt
> > of describing it, in file-local-name's doc string, viz.:
> >
> >   It returns a file name which can be used directly as argument of
> >   ‘process-file’, ‘start-file-process’, or ‘shell-command’.
> >
> > is IMO unsatisfactory, because it describes how results could be used,
> > not what they are.
> 
> The docstring speaks about.
> 
> --8<---------------cut here---------------start------------->8---
> PROGRAM and PROGRAM-ARGS might be file names.  They are not
> objects of file name handler invocation.
> --8<---------------cut here---------------end--------------->8---
> 
> The Elisp manual speaks about. (info "(elisp) Asynchronous Processes")
> 
> --8<---------------cut here---------------start------------->8---
> This function does not try to invoke file name handlers for PROGRAM
> or for the rest of ARGS.
> --8<---------------cut here---------------end--------------->8---

Thanks, I made that even more explicit and clear.