bug#33050: 27.0.50; [macOS] Problem with process input with process-connection-type nil

[Eli Zaretskii]

> From: Filipp Gunbin <fgunbin@fastmail.fm>
> Cc: fitzsim@fitzsim.org,  33050@debbugs.gnu.org,  alan@idiocy.org
> Date: Thu, 25 Oct 2018 21:10:25 +0300
> 
> On 25/10/2018 20:29 +0300, Eli Zaretskii wrote:
> 
> >> From: Filipp Gunbin <fgunbin@fastmail.fm>
> >> Cc: fitzsim@fitzsim.org,  33050@debbugs.gnu.org, alan@idiocy.org
> >> Date: Thu, 25 Oct 2018 20:10:06 +0300
> >>
> >> > I'm probably missing something: why are you still trying to find a
> >> > solution, when one was already found?  What's wrong with setting
> >> > process-connection-type non-nil in this case, at least for Darwin?
> >>
> >> Yes, setting p-c-t to t worked from the start, but it's just a
> >> workaround - there's still problem with p-c-t nil.
> >>
> >> I'm currently running with this patch, which is based on Alan's fix in
> >> callproc.c (call_process() had the same problem on Darwin).
> >
> > I don't understand why: using nil process-connection-type for programs
> > that prompt the user is a bug anyway.
> 
> I think these are separate problems.

They are, indeed; and I thought this bug report is about the problem
with ldapsearch.  If you think the way we start subprocesses on macOS
needs fixing, it should be a separate bug, most probably with a
different urgency and severity.

> So it again became possible that we call setsid() after vfork(), and
> this I believe is the root case of the current problem.

Once again, I believe the root cause is that process-connection-type
has the wrong value.