[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#32850: 27.0.50; window-swap-states doesn't swap window prev/next-buf
From: |
martin rudalics |
Subject: |
bug#32850: 27.0.50; window-swap-states doesn't swap window prev/next-buffers |
Date: |
Wed, 17 Oct 2018 09:31:37 +0200 |
> I'd like to make it customizable by using the existing customization in
> the arg WRITABLE of window-state-get and window-persistent-parameters,
> even though formally prev/next-buffers is not a window parameter (maybe
> it should be, I don't know).
Always keep in mind that prev_buffers and next_buffers need special
treatment in mark_object to make sure that dead buffers from window
configurations stored somewhere (for example in a register) get their
entries deleted and can be eventually reclaimed. This is something I
completely disregarded when writing the original code for navigating
these buffer lists. Stefan then wrote the code to do that in
mark_object.
> Done, with a small change: even though set-marker is idempotent in regard
> to its POSITION arg (i.e. if POSITION is a marker, it creates an identical
> marker), I added a check to not create a new one. OTOH, get-buffer is
> idempotent too, but it seems window-state-put never receives a structure
> with buffer objects, and I'm not sure why window-state-get should always
> use buffer-name regardless of the value WRITABLE, i.e. why should it return
> buffer names as strings instead of buffer objects even when WRITABLE is nil?
Maybe because I didn't care about non-writable states back then. But
you're obviously right. Buffers can be renamed at will and in that
case we might have a state with a non-existent buffer or even buffers
with names switched and therefore invalid values of start or point.
So yes: Please use a buffer object for non-writable states.
martin
- bug#32850: 27.0.50; window-swap-states doesn't swap window prev/next-buffers, martin rudalics, 2018/10/01
- bug#32850: 27.0.50; window-swap-states doesn't swap window prev/next-buffers, Juri Linkov, 2018/10/08
- bug#32850: 27.0.50; window-swap-states doesn't swap window prev/next-buffers, martin rudalics, 2018/10/09
- bug#32850: 27.0.50; window-swap-states doesn't swap window prev/next-buffers, Juri Linkov, 2018/10/15
- bug#32850: 27.0.50; window-swap-states doesn't swap window prev/next-buffers, martin rudalics, 2018/10/16
- bug#32850: 27.0.50; window-swap-states doesn't swap window prev/next-buffers, Juri Linkov, 2018/10/16
- bug#32850: 27.0.50; window-swap-states doesn't swap window prev/next-buffers,
martin rudalics <=
- bug#32850: 27.0.50; window-swap-states doesn't swap window prev/next-buffers, Juri Linkov, 2018/10/17
- bug#32850: 27.0.50; window-swap-states doesn't swap window prev/next-buffers, martin rudalics, 2018/10/18
- bug#32850: 27.0.50; window-swap-states doesn't swap window prev/next-buffers, Juri Linkov, 2018/10/18
- bug#32850: 27.0.50; window-swap-states doesn't swap window prev/next-buffers, martin rudalics, 2018/10/19
- bug#32850: 27.0.50; window-swap-states doesn't swap window prev/next-buffers, Juri Linkov, 2018/10/20
- bug#32850: 27.0.50; window-swap-states doesn't swap window prev/next-buffers, martin rudalics, 2018/10/21
- bug#32850: 27.0.50; window-swap-states doesn't swap window prev/next-buffers, Juri Linkov, 2018/10/21
- bug#32850: 27.0.50; window-swap-states doesn't swap window prev/next-buffers, martin rudalics, 2018/10/22
- bug#32850: 27.0.50; window-swap-states doesn't swap window prev/next-buffers, Juri Linkov, 2018/10/23
- bug#32850: 27.0.50; window-swap-states doesn't swap window prev/next-buffers, martin rudalics, 2018/10/24