[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#31240: 26.1; mouse-save-then-kill does not kill rectangles
From: |
Charles A. Roelli |
Subject: |
bug#31240: 26.1; mouse-save-then-kill does not kill rectangles |
Date: |
Sun, 30 Sep 2018 17:45:06 +0200 |
Thanks for the updated patch, it looks good to me. I have one small
suggestion:
> +(defun rectangle-position-as-coordinates (position)
> + "Return an integer buffer position as a (COL . LINE) coordinate."
> + (save-excursion
> + (goto-char position)
> + (let ((col (current-column))
> + (line (progn
> + (beginning-of-line)
> + (count-lines 1 position))))
> + (cons col line))))
(beginning-of-line) could be replaced with (forward-line 0), which is
guaranteed to be at the beginning of the line.
- bug#31240: 26.1; mouse-save-then-kill does not kill rectangles, (continued)
- bug#31240: 26.1; mouse-save-then-kill does not kill rectangles, Federico Tedin, 2018/09/22
- bug#31240: 26.1; mouse-save-then-kill does not kill rectangles, Charles A. Roelli, 2018/09/23
- bug#31240: 26.1; mouse-save-then-kill does not kill rectangles, Federico Tedin, 2018/09/23
- bug#31240: 26.1; mouse-save-then-kill does not kill rectangles, Charles A. Roelli, 2018/09/24
- bug#31240: 26.1; mouse-save-then-kill does not kill rectangles, Federico Tedin, 2018/09/25
- bug#31240: 26.1; mouse-save-then-kill does not kill rectangles, Charles A. Roelli, 2018/09/27
- bug#31240: 26.1; mouse-save-then-kill does not kill rectangles, Federico Tedin, 2018/09/27
- bug#31240: 26.1; mouse-save-then-kill does not kill rectangles, martin rudalics, 2018/09/28
- bug#31240: 26.1; mouse-save-then-kill does not kill rectangles, Federico Tedin, 2018/09/29
- bug#31240: 26.1; mouse-save-then-kill does not kill rectangles, martin rudalics, 2018/09/30
- bug#31240: 26.1; mouse-save-then-kill does not kill rectangles,
Charles A. Roelli <=
- bug#31240: 26.1; mouse-save-then-kill does not kill rectangles, Federico Tedin, 2018/09/30
- bug#31240: 26.1; mouse-save-then-kill does not kill rectangles, Eli Zaretskii, 2018/09/30
- bug#31240: 26.1; mouse-save-then-kill does not kill rectangles, martin rudalics, 2018/09/30
- bug#31240: 26.1; mouse-save-then-kill does not kill rectangles, Federico Tedin, 2018/09/30
- bug#31240: 26.1; mouse-save-then-kill does not kill rectangles, Charles A. Roelli, 2018/09/29