bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#29923: [PATCH] Skip writing empty abbrev tables


From: Allen Li
Subject: bug#29923: [PATCH] Skip writing empty abbrev tables
Date: Tue, 18 Sep 2018 19:55:38 -0700

On Tue, Sep 18, 2018 at 3:53 PM Noam Postavsky <npostavs@gmail.com> wrote:
>
> Allen Li <darkfeline@felesatra.moe> writes:
>
> > The system abbrev omitting worked (if readable is nil); it's
> > implemented in abbrev--write.
> > However, that doesn't allow us to skip writing a table if it only
> > contains system abbrevs;
> > we'll still see a table with abbrevs, write the opening of the
> > define-abbrev-table form,
> > and then realize in abbrev-write that all of the abbrevs are system abbrevs.
>
> Ah, it would be good to have this information in the commit message, as
> the patch is a bit confusing to read otherwise.

Done.  I have also removed the system abbrev check in abbrev--write since
it is redundant now and this is the only place it is called.

Attachment: 0001-Skip-writing-empty-abbrev-tables.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]