[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#32372: [PATCH] Add "uuid" to thing-at-point.el
From: |
Raimon Grau |
Subject: |
bug#32372: [PATCH] Add "uuid" to thing-at-point.el |
Date: |
Sat, 11 Aug 2018 12:37:51 +0100 |
Ivan Shmakov <ivan@siamics.net> writes:
> > What to use here is a mostly a matter of personal style, and a bit of
> > a bikeshed at that, so you are likely to get varied opinions. At the
> > end of the day it doesn’t really matter what you go with.
>
> Yes.
I ended up using when (and indenting it correctly) if that's ok.
>From f7c76007aef325abc31871db108e7e48fe46022c Mon Sep 17 00:00:00 2001
From: Raimon Grau <raimonster@gmail.com>
Date: Sun, 5 Aug 2018 22:47:30 +0100
Subject: [PATCH] Add uuid as allowed thingatpt symbol
* etc/NEWS: Mention changes in thingatpt.el.
* lisp/thingatpt.el (thing-at-point-uuid-regexp): Add regexp for uuid.
(top-level): Add 'bounds-of-thing-at-point' operation for 'uuid'.
* test/lisp/thingatpt-tests.el: Add tests for uuid at point.
---
etc/NEWS | 6 ++++++
lisp/thingatpt.el | 25 ++++++++++++++++++++++---
test/lisp/thingatpt-tests.el | 5 ++++-
3 files changed, 32 insertions(+), 4 deletions(-)
diff --git a/etc/NEWS b/etc/NEWS
index a1c12a6..57b2586 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -96,6 +96,12 @@ option 'vc-hg-symbolic-revision-styles' to the value
'("{rev}")'.
---
** shadowfile.el has been rewritten to support Tramp file names.
+---
+** thingatpt.el supports a new "thing" called 'uuid'.
+
+A symbol 'uuid' can be passed to thing-at-point and it returns the
+UUID at point.
+
* New Modes and Packages in Emacs 26.2
diff --git a/lisp/thingatpt.el b/lisp/thingatpt.el
index 6a978fe..abeb167 100644
--- a/lisp/thingatpt.el
+++ b/lisp/thingatpt.el
@@ -58,7 +58,7 @@ forward-thing
"Move forward to the end of the Nth next THING.
THING should be a symbol specifying a type of syntactic entity.
Possibilities include `symbol', `list', `sexp', `defun',
-`filename', `url', `email', `word', `sentence', `whitespace',
+`filename', `url', `email', `uuid', `word', `sentence', `whitespace',
`line', and `page'."
(let ((forward-op (or (get thing 'forward-op)
(intern-soft (format "forward-%s" thing)))))
@@ -73,7 +73,7 @@ bounds-of-thing-at-point
"Determine the start and end buffer locations for the THING at point.
THING should be a symbol specifying a type of syntactic entity.
Possibilities include `symbol', `list', `sexp', `defun',
-`filename', `url', `email', `word', `sentence', `whitespace',
+`filename', `url', `email', `uuid', `word', `sentence', `whitespace',
`line', and `page'.
See the file `thingatpt.el' for documentation on how to define a
@@ -131,7 +131,7 @@ thing-at-point
"Return the THING at point.
THING should be a symbol specifying a type of syntactic entity.
Possibilities include `symbol', `list', `sexp', `defun',
-`filename', `url', `email', `word', `sentence', `whitespace',
+`filename', `url', `email', `uuid', `word', `sentence', `whitespace',
`line', `number', and `page'.
When the optional argument NO-PROPERTIES is non-nil,
@@ -554,6 +554,25 @@ thing-at-point-email-regexp
(put 'buffer 'end-op (lambda () (goto-char (point-max))))
(put 'buffer 'beginning-op (lambda () (goto-char (point-min))))
+;; UUID
+
+(defconst thing-at-point-uuid-regexp
+ (rx bow
+ (repeat 8 hex-digit) "-"
+ (repeat 4 hex-digit) "-"
+ (repeat 4 hex-digit) "-"
+ (repeat 4 hex-digit) "-"
+ (repeat 12 hex-digit)
+ eow)
+ "A regular expression matching a UUID.
+
+See RFC 4122 for the description of the format.")
+
+(put 'uuid 'bounds-of-thing-at-point
+ (lambda ()
+ (when (thing-at-point-looking-at thing-at-point-uuid-regexp 36)
+ (cons (match-beginning 0) (match-end 0)))))
+
;; Aliases
(defun word-at-point ()
diff --git a/test/lisp/thingatpt-tests.el b/test/lisp/thingatpt-tests.el
index cfb57de..b4a5fd9 100644
--- a/test/lisp/thingatpt-tests.el
+++ b/test/lisp/thingatpt-tests.el
@@ -65,7 +65,10 @@ thing-at-point-test-data
("http://example.com/ab)c" 4 url "http://example.com/ab)c")
;; URL markup, lacking schema
("<url:foo@example.com>" 1 url "mailto:foo@example.com")
- ("<url:ftp.example.net/abc/>" 1 url "ftp://ftp.example.net/abc/"))
+ ("<url:ftp.example.net/abc/>" 1 url "ftp://ftp.example.net/abc/")
+ ;; UUID, only hex is allowed
+ ("01234567-89ab-cdef-ABCD-EF0123456789" 1 uuid
"01234567-89ab-cdef-ABCD-EF0123456789")
+ ("01234567-89ab-cdef-ABCD-EF012345678G" 1 uuid nil))
"List of thing-at-point tests.
Each list element should have the form
--
2.7.4
- bug#32372: [PATCH] Add "uuid" to thing-at-point.el, (continued)
- bug#32372: [PATCH] Add "uuid" to thing-at-point.el, Raimon Grau, 2018/08/06
- bug#32372: [PATCH] Add "uuid" to thing-at-point.el, Noam Postavsky, 2018/08/06
- bug#32372: [PATCH] Add "uuid" to thing-at-point.el, Raimon Grau, 2018/08/07
- bug#32372: [PATCH] Add "uuid" to thing-at-point.el, Ivan Shmakov, 2018/08/07
- bug#32372: [PATCH] Add "uuid" to thing-at-point.el, Basil L. Contovounesios, 2018/08/07
- bug#32372: [PATCH] Add "uuid" to thing-at-point.el, Raimon Grau, 2018/08/09
- bug#32372: [PATCH] Add "uuid" to thing-at-point.el, Ivan Shmakov, 2018/08/09
- bug#32372: [PATCH] Add "uuid" to thing-at-point.el, Raimon Grau, 2018/08/09
- bug#32372: [PATCH] Add "uuid" to thing-at-point.el, Basil L. Contovounesios, 2018/08/09
- bug#32372: [PATCH] Add "uuid" to thing-at-point.el, Ivan Shmakov, 2018/08/10
- bug#32372: [PATCH] Add "uuid" to thing-at-point.el,
Raimon Grau <=
- bug#32372: [PATCH] Add "uuid" to thing-at-point.el, Noam Postavsky, 2018/08/13