bug#31782: 26.1; dired-recursive-deletes broken

[Noam Postavsky]

tags 31782 fixed
close 31782 26.2
quit

Eli Zaretskii <eliz@gnu.org> writes:

>> +;; For backward compatibility check if short y/n answers are preferred.
>> +(defcustom read-answer-short 'auto
>> +  "Control whether `read-answer' accepts short answers.
>
> This is unnecessarily vague.  How about
>
>   If non-nil, `read-answer' accepts single-character answers.
>
> with all the rest intact?

Okay, I'm always a bit unsure how to summarize these multi-way choice
options.

>> I guess assoc-delete-all should be announced in NEWS too?
>
> Yes, please.

>> +(defcustom read-answer-short 'auto
>> +  "Control whether `read-answer' accepts short answers.
>> +If t, accept short (single key-press) answers to the question.
>> +If nil, require long answers.  If `auto', accept short answers if
>> +the function cell of `yes-or-no-p' is set to `y-or-on-p'."
>> +  :type '(choice (const :tag "Accept short answers" t)
>> +                 (const :tag "Require long answer" nil)
>> +                 (const :tag "Guess preference" auto))
>>    :version "27.1"
>
> The :version tag should change, right?

Oh, I got confused with the multiple branches.  Should be fixed now.

>> And once backported, we should remove the announcement from 27.1 NEWS,
>> since the new function it will already be introduced in 26.2:
>
> Right.

All done; [1: cc233365a9] in emacs-26, [2: 95050a5841], [3: 84ecc48d1f],
and [4: 111916596f] in master.

[1: cc233365a9]: 2018-08-04 11:37:39 -0400
  New function read-answer (Bug#31782)
  
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=cc233365a925dcf9fa7270630819f2e6e75280da

[2: 95050a5841]: 2018-08-04 11:55:40 -0400
  Respect non-saved value of `read-short-answer' (Bug#31782)
  
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=95050a5841c01bbcb6e8a82838881eee7879b7b9

[3: 84ecc48d1f]: 2018-08-04 11:55:40 -0400
  ; etc/NEWS: Remove read-answer, it was backported to v26
  
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=84ecc48d1f9a98626977151aca332cfd4d7361b9

[4: 111916596f]: 2018-08-04 12:00:43 -0400
  ; (read-answer-short): Fix :version setting for backport
  
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=111916596fc8518cffcd0c32cf0f99e638f6ec24