[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#31951: 27.0.50; [PATCH] server-save-buffers-kill-terminal should res
From: |
Noam Postavsky |
Subject: |
bug#31951: 27.0.50; [PATCH] server-save-buffers-kill-terminal should respect save-some-buffers-default-predicate |
Date: |
Sun, 24 Jun 2018 09:37:26 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
João Távora <joaotavora@gmail.com> writes:
> If the Emacs client was started without an explicit list of buffers to
> edit, save-some-buffers is called with t for PRED (save all buffers),
> but that was before save-some-buffers-default-predicate existed.
>
> I don't see any reason why save-some-buffers-default-predicate shouldn't
> be respected in server-save-buffers-kill-terminal (of course if ARG is
> non-nil, we do pass t so that the previous behaviour remains).
> ;; If client is bufferless, emulate a normal Emacs exit
> ;; and offer to save all buffers. Otherwise, offer to
> ;; save only the buffers belonging to the client.
> (save-some-buffers
> - arg (if buffers
> - (lambda () (memq (current-buffer) buffers))
> - t))
> + arg (and buffers
> + (lambda () (memq (current-buffer) buffers))
> + (and arg t)))
I think you meant
+ arg (if buffers
+ (lambda () (memq (current-buffer) buffers))
+ (and arg t))
But I'm not sure if this change makes sense, seeing as
save-buffers-kill-emacs also ignores
save-some-buffers-default-predicate:
(defun save-buffers-kill-emacs (&optional arg)
[...]
;; Don't use save-some-buffers-default-predicate, because we want
;; to ask about all the buffers before killing Emacs.
(save-some-buffers arg t)
- bug#31951: 27.0.50; [PATCH] server-save-buffers-kill-terminal should respect save-some-buffers-default-predicate, João Távora, 2018/06/23
- bug#31951: 27.0.50; [PATCH] server-save-buffers-kill-terminal should respect save-some-buffers-default-predicate,
Noam Postavsky <=
- bug#31951: 27.0.50; [PATCH] server-save-buffers-kill-terminal should respect save-some-buffers-default-predicate, João Távora, 2018/06/24
- bug#31951: 27.0.50; [PATCH] server-save-buffers-kill-terminal should respect save-some-buffers-default-predicate, Noam Postavsky, 2018/06/24
- bug#31951: 27.0.50; [PATCH] server-save-buffers-kill-terminal should respect save-some-buffers-default-predicate, João Távora, 2018/06/25
- bug#31951: 27.0.50; [PATCH] server-save-buffers-kill-terminal should respect save-some-buffers-default-predicate, Noam Postavsky, 2018/06/25
- bug#31951: 27.0.50; [PATCH] server-save-buffers-kill-terminal should respect save-some-buffers-default-predicate, João Távora, 2018/06/26
- bug#31951: 27.0.50; [PATCH] server-save-buffers-kill-terminal should respect save-some-buffers-default-predicate, João Távora, 2018/06/27