[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#31792: 27.0.50; Regression in #'labels, recent versions
From: |
Stefan Monnier |
Subject: |
bug#31792: 27.0.50; Regression in #'labels, recent versions |
Date: |
Wed, 13 Jun 2018 09:16:01 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
> diff --git a/lisp/emacs-lisp/cl.el b/lisp/emacs-lisp/cl.el
> index d53c8e0bbc..85deb8cb4f 100644
> --- a/lisp/emacs-lisp/cl.el
> +++ b/lisp/emacs-lisp/cl.el
> @@ -466,8 +466,9 @@ labels
> (push var sets)
> (push (cons (car binding)
> `(lambda (&rest cl-labels-args)
> - (cl-list* 'funcall ',var
> - cl-labels-args)))
> + (if (eq (car cl-labels-args) cl--labels-magic)
> + (list cl--labels-magic ',var)
> + (cl-list* 'funcall ',var cl-labels-args))))
> newenv)))
> (macroexpand-all `(lexical-let ,vars (setq ,@sets) ,@body) newenv)))
Looks good, but please add a comment before the call to macroexpand-all
reminding that lexical-let installs a macroexpander for `function` that
ends up calling cl--labels-convert.
Stefan
- bug#31792: 27.0.50; Regression in #'labels, recent versions, Aidan Kehoe, 2018/06/11
- bug#31792: 27.0.50; Regression in #'labels, recent versions, Noam Postavsky, 2018/06/11
- bug#31792: 27.0.50; Regression in #'labels, recent versions, Noam Postavsky, 2018/06/12
- bug#31792: 27.0.50; Regression in #'labels, recent versions,
Stefan Monnier <=
- bug#31792: 27.0.50; Regression in #'labels, recent versions, Noam Postavsky, 2018/06/13
- bug#31792: 27.0.50; Regression in #'labels, recent versions, Stefan Monnier, 2018/06/13
- bug#31792: 27.0.50; Regression in #'labels, recent versions, Noam Postavsky, 2018/06/14
- bug#31792: 27.0.50; Regression in #'labels, recent versions, Stefan Monnier, 2018/06/14
- bug#31792: 27.0.50; Regression in #'labels, recent versions, Noam Postavsky, 2018/06/19
Message not available