[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#31764: 26.1; Point in VC change log is not centered as documented
From: |
Noam Postavsky |
Subject: |
bug#31764: 26.1; Point in VC change log is not centered as documented |
Date: |
Mon, 11 Jun 2018 20:10:17 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
tags 31764 + patch
quit
Eli Zaretskii <eliz@gnu.org> writes:
>> I can reproduce this on GNU/Linux, but not on Windows (both tested with
>> latest emacs-26).
>
> Isn't that strange? The code involved isn't platform specific.
Looks like a matter of timing, if I add a (sit-for 1) to beginning of
vc-exec-after (or use edebug), then I can reproduce on Windows too.
Adding a save-excursion seems to fix it.
>From 895d29eb6b010093245a67d7f05808d765195b7a Mon Sep 17 00:00:00 2001
From: Noam Postavsky <npostavs@gmail.com>
Date: Mon, 11 Jun 2018 20:00:54 -0400
Subject: [PATCH v1] Keep vc-print-log from putting point at buffer end
(Bug#31764)
* lisp/vc/vc.el (vc-print-log-internal): Use `save-excursion' around
`vc-print-log-setup-buttons'.
---
lisp/vc/vc.el | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el
index 93e9c25cbf..41a76e0007 100644
--- a/lisp/vc/vc.el
+++ b/lisp/vc/vc.el
@@ -2256,8 +2256,9 @@ vc-print-log-internal
(vc-call-backend bk 'print-log files-arg buf shortlog
(when is-start-revision working-revision) limit))
(lambda (_bk _files-arg ret)
- (vc-print-log-setup-buttons working-revision
- is-start-revision limit ret))
+ (save-excursion
+ (vc-print-log-setup-buttons working-revision
+ is-start-revision limit ret)))
;; When it's nil, point really shouldn't move (bug#15322).
(when working-revision
(lambda (bk)
--
2.11.0
- bug#31764: 26.1; Point in VC change log is not centered as documented, (continued)
- bug#31764: 26.1; Point in VC change log is not centered as documented, Carlos Pita, 2018/06/08
- bug#31764: 26.1; Point in VC change log is not centered as documented, Eli Zaretskii, 2018/06/08
- bug#31764: 26.1; Point in VC change log is not centered as documented, Carlos Pita, 2018/06/08
- bug#31764: 26.1; Point in VC change log is not centered as documented, Carlos Pita, 2018/06/08
- bug#31764: 26.1; Point in VC change log is not centered as documented, Carlos Pita, 2018/06/08
- bug#31764: 26.1; Point in VC change log is not centered as documented, Carlos Pita, 2018/06/08
- bug#31764: 26.1; Point in VC change log is not centered as documented, Noam Postavsky, 2018/06/08
- bug#31764: 26.1; Point in VC change log is not centered as documented, Carlos Pita, 2018/06/08
- bug#31764: 26.1; Point in VC change log is not centered as documented, Eli Zaretskii, 2018/06/09
- bug#31764: 26.1; Point in VC change log is not centered as documented, Carlos Pita, 2018/06/09
- bug#31764: 26.1; Point in VC change log is not centered as documented,
Noam Postavsky <=
- bug#31764: 26.1; Point in VC change log is not centered as documented, Eli Zaretskii, 2018/06/11
- bug#31764: 26.1; Point in VC change log is not centered as documented, Noam Postavsky, 2018/06/14