[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#30846: 26.0.91; debug-watch of kill-all-local-variables triggers 'as
From: |
Noam Postavsky |
Subject: |
bug#30846: 26.0.91; debug-watch of kill-all-local-variables triggers 'assertion failed: found == !EQ (blv->defcell, blv->valcell)' |
Date: |
Thu, 22 Mar 2018 20:20:13 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) |
Stefan Monnier <monnier@IRO.UMontreal.CA> writes:
> If you feel this is too risky for emacs-26, I wouldn't blame you (this
> is pretty tricky code): while the assertion crashes Emacs, a normal
> build without assertions will likely not notice the problem at all.
> I came up with a test case that catches the problem, but I think that in
> "real" life it's very unlikely to cause a problem.
Should we disable the assertion in emacs-26 then?
And would the diff below updating comments on struct
Lisp_Buffer_Local_Value be correct?
--- i/src/lisp.h
+++ w/src/lisp.h
@@ -2593,10 +2593,10 @@ XUSER_PTR (Lisp_Object a)
variable, you must first make sure the right binding is loaded;
then you can access the value in (or through) `realvalue'.
- `buffer' and `frame' are the buffer and frame for which the loaded
- binding was found. If those have changed, to make sure the right
+ `where' is the buffer for which the loaded
+ binding was found. If it has changed, to make sure the right
binding is loaded it is necessary to find which binding goes with
- the current buffer and selected frame, then load it. To load it,
+ the current buffer, then load it. To load it,
first unload the previous binding, then copy the value of the new
binding into `realvalue' (or through it). Also update
LOADED-BINDING to point to the newly loaded binding.
@@ -2615,14 +2615,14 @@ XUSER_PTR (Lisp_Object a)
bool_bf found : 1;
/* If non-NULL, a forwarding to the C var where it should also be set. */
union Lisp_Fwd *fwd; /* Should never be (Buffer|Kboard)_Objfwd. */
- /* The buffer or frame for which the loaded binding was found. */
+ /* The buffer for which the loaded binding was found. */
Lisp_Object where;
/* A cons cell that holds the default value. It has the form
(SYMBOL . DEFAULT-VALUE). */
Lisp_Object defcell;
/* The cons cell from `where's parameter alist.
It always has the form (SYMBOL . VALUE)
- Note that if `forward' is non-nil, VALUE may be out of date.
+ Note that if `fwd' is non-NULL, VALUE may be out of date.
Also if the currently loaded binding is the default binding, then
this is `eq'ual to defcell. */
Lisp_Object valcell;
bug#30846: 26.0.91; debug-watch of kill-all-local-variables triggers 'assertion failed: found == !EQ (blv->defcell, blv->valcell)', Stefan Monnier, 2018/03/22
- bug#30846: 26.0.91; debug-watch of kill-all-local-variables triggers 'assertion failed: found == !EQ (blv->defcell, blv->valcell)', Eli Zaretskii, 2018/03/22
- bug#30846: 26.0.91; debug-watch of kill-all-local-variables triggers 'assertion failed: found == !EQ (blv->defcell, blv->valcell)',
Noam Postavsky <=
- bug#30846: 26.0.91; debug-watch of kill-all-local-variables triggers 'assertion failed: found == !EQ (blv->defcell, blv->valcell)', Eli Zaretskii, 2018/03/23
- bug#30846: 26.0.91; debug-watch of kill-all-local-variables triggers 'assertion failed: found == !EQ (blv->defcell, blv->valcell)', Stefan Monnier, 2018/03/23
- bug#30846: 26.0.91; debug-watch of kill-all-local-variables triggers 'assertion failed: found == !EQ (blv->defcell, blv->valcell)', Eli Zaretskii, 2018/03/23
- bug#30846: 26.0.91; debug-watch of kill-all-local-variables triggers 'assertion failed: found == !EQ (blv->defcell, blv->valcell)', Stefan Monnier, 2018/03/23
bug#30846: 26.0.91; debug-watch of kill-all-local-variables triggers 'assertion failed: found == !EQ (blv->defcell, blv->valcell)', Stefan Monnier, 2018/03/23