[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#30489: 26.0.91; [PATCH] Data associated with json-readtable-error no
|
From: |
Noam Postavsky |
|
Subject: |
bug#30489: 26.0.91; [PATCH] Data associated with json-readtable-error not a list |
|
Date: |
Fri, 16 Mar 2018 05:52:06 -0400 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) |
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Noam Postavsky <npostavs@gmail.com>
>> Date: Thu, 15 Mar 2018 22:39:18 -0400
>> Cc: 30489@debbugs.gnu.org
>>
>> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
>>
>> > - `(cond ,@res (t (signal 'json-readtable-error ,char)))))
>> > + `(cond ,@res (t (signal 'json-readtable-error ,(list char))))))
>>
>> > When signalling json-readtable-error, the macro json-readtable-dispatch
>> > passes the unrecognised character as error data verbatim, rather than as
>> > a list. Attached is a patch which fixes this.
>>
>> Should this be applied to emacs-26? It seems to fix a regression
>> relative to Emacs 25 (where this error just had `nil' as the data) and
>> the patch looks safe enough.
>
> What change(s) introduced the regression?
[1: 9314e6c56e]: 2017-09-04 03:40:30 -0400
Embed JSON readtable into json-read
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=9314e6c56e248a5060a6c125e2088c4fbffe123b