[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#19045: 25.0.50; [PATCH] vc-git-print-log use --follow
From: |
Juri Linkov |
Subject: |
bug#19045: 25.0.50; [PATCH] vc-git-print-log use --follow |
Date: |
Sun, 11 Feb 2018 23:22:59 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) |
> Juri, can you please re-check with directories? They seem to work
> fine here, so disabling them in this case sounds unnecessary.
Please clarify where directories work fine: in git command line
or in Emacs using vc-git?
In the command line of git version 1.9.1 running git log on two files
(command line copied from *Messages* when vc-command-messages is t)
git --no-pager log --no-color --follow -n 2000 -- vc-dispatcher.el vc-git.el
fails with the error:
usage: git logs can only follow renames on one pathname at a time
whereas running git on one directory ‘vc’
git --no-pager log --no-color --follow -n 2000 -- vc
doesn't fail. Although I can't confirm the correctness of the output log:
it seems the option ‘--follow’ has no effect on directories.
Now there is a different story for vc-git.el. There are 4 versions of it:
1. the initial version without the option added in ‘vc-git-print-log’
2. the old version that always used "--follow"
3. the previous version that added "--follow" only
when the arg ‘files’ contains no directories
4. the current version that additionally checks the length of ‘files’
and adds "--follow" only for a single file in ‘files’.
Which version did you check?
- bug#19045: 25.0.50; [PATCH] vc-git-print-log use --follow, (continued)
bug#19045: 25.0.50; [PATCH] vc-git-print-log use --follow, Eli Zaretskii, 2018/02/10
- bug#19045: 25.0.50; [PATCH] vc-git-print-log use --follow, Juri Linkov, 2018/02/10
- bug#19045: 25.0.50; [PATCH] vc-git-print-log use --follow, Eli Zaretskii, 2018/02/11
- bug#19045: 25.0.50; [PATCH] vc-git-print-log use --follow, Andreas Schwab, 2018/02/11
- bug#19045: 25.0.50; [PATCH] vc-git-print-log use --follow, Eli Zaretskii, 2018/02/11
- bug#19045: 25.0.50; [PATCH] vc-git-print-log use --follow, Andreas Schwab, 2018/02/11
- bug#19045: 25.0.50; [PATCH] vc-git-print-log use --follow, Eli Zaretskii, 2018/02/11
- bug#19045: 25.0.50; [PATCH] vc-git-print-log use --follow,
Juri Linkov <=
- bug#19045: 25.0.50; [PATCH] vc-git-print-log use --follow, Eli Zaretskii, 2018/02/12
- bug#19045: 25.0.50; [PATCH] vc-git-print-log use --follow, Juri Linkov, 2018/02/12
- bug#19045: 25.0.50; [PATCH] vc-git-print-log use --follow, Eli Zaretskii, 2018/02/13